fix Python version handling for interactive tests #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the Python version is set appropriately in the case of tests such as the interactive ones that run the 'maya' executable directly rather than invoking 'mayapy' or 'mayapy2'.
mattyjams
deleted the
pr/fix_Python_version_handling_for_interactive_tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address the issue raised in #805. Since the interactive tests launch the
mayabinary rather thanmayapyormayapy2, they were always running using Python 3 in Maya 2021/preview releases.In addition to setting
MAYA_PY_EXECUTABLEto eithermayapyormayapy2inFindMaya.cmake, we now also setMAYA_PY_VERSIONto either2or3as appropriate. We then use that CMake variable to setMAYA_PYTHON_VERSIONwhen setting up the environment for running the tests. Maya 2020 and earlier will simply ignore that environment variable.I've verified that the interactive tests pass running Maya PR 119 and Python 2 on Linux. I'm not actually setup to build against Python 3 yet, so if someone is able to verify that configuration for me, that would be great. These tests get skipped by the preflight builds, so any issues likely would not show up there.