Prepare for upcoming UFE interface changes to support Maya transform … #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kxl-adsk
added
ufe
kxl-adsk
approved these changes
Oct 13, 2020
seando-adsk
reviewed
Oct 13, 2020
Comment on lines
63
to
67
| #if UFE_PREVIEW_VERSION_NUM >= 2025 | ||
| bool set(double x, double y, double z) override; | ||
| #else | ||
| bool translate(double x, double y, double z) override; | ||
| #endif |
There was a problem hiding this comment.
Looking at UFE v1 I see the translate method exists. So I think you need more than just a UFE_PREVIEW_VERSION_NUM check here. Because later when we cleanup and remove these (because Maya PR has this version) we will still need an ifdef to support the UFE v1 version with translate (not set) method.
There was a problem hiding this comment.
Great work thanks. I think we should use this same pattern moving forwards. It will be a great help when we come back and cleanup this UFE preview checks.
ppt-adsk
added
the
ready-for-merge
seando-adsk
reviewed
Oct 14, 2020
| @@ -55,7 +55,7 @@ namespace | |||
| template<typename T> | |||
| void addMetadataCount(const T& op, std::string& tooltip, bool& needComma, const std::string& singular, const std::string& plural) | |||
| { | |||
| T::ItemVector refs; | |||
| typename T::ItemVector refs; | |||
There was a problem hiding this comment.
Thanks for fixing this.
seando-adsk
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…stack.
The changes are mostly minor renames, to conform to upcoming UFE 0.2.25 interfaces.