MAYA-105577 MAYA-105597 Improve accessor plug name and cleanup tests #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kxl-adsk
added
proxy
ppt-adsk
requested changes
Oct 16, 2020
| @@ -150,6 +151,16 @@ _FindOrCreateMayaNumericAttr( | |||
| attr.setUsedAsColor(true); | |||
| } | |||
|
|
|||
| const unsigned int numChildren = MFnCompoundAttribute(attrObj).numChildren(); | |||
| if(numChildren < 4u) { | |||
There was a problem hiding this comment.
This can't be right, you must be off by one. If your tests didn't catch this, then I guess we're missing a bit of coverage :)
There was a problem hiding this comment.
Ehh...late-night coding. Of course, it can't be right.
test/testUtils/ufeUtils.py
Outdated
| @@ -55,6 +55,26 @@ def selectPath(path, replace=False): | |||
| else: | |||
| ufeSelectCmd.append(sceneItem) | |||
|
|
|||
| def makeUfePath(dagPath, sdfPath=None): | |||
There was a problem hiding this comment.
Quite oddly named, I would say... I would have expected makeUfePath to return a Ufe.Path, not a scene item!
There was a problem hiding this comment.
Right. Any suggestions for the name?
There was a problem hiding this comment.
createUfeSceneItem(), createUfeItem(), makeUfeSceneItem(), makeUfeItem(). Take your pick!
ppt-adsk
approved these changes
Oct 18, 2020
kxl-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some polishing that was raised in #594.
Commit bad3130 addresses #594 (comment)
Commit 7e951ed is cleaning up code duplication in unit test #594 (comment)