Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow usdPreviewSurface to exist without input connections #907

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Allow usdPreviewSurface to exist without input connections #907

merged 1 commit into from
Nov 10, 2020

Conversation

JGamache-autodesk
Copy link
Collaborator

Fixes #897

@JGamache-autodesk JGamache-autodesk added bug Something isn't working ready-for-merge Development process is finished, PR is ready for merge labels Nov 9, 2020
@kxl-adsk
Copy link

kxl-adsk commented Nov 9, 2020

@dgovil would you like to test it before we merge?

@dgovil
Copy link
Collaborator

dgovil commented Nov 9, 2020

Sure. Just building locally now. Thanks for the quick turnaround

@dgovil
Copy link
Collaborator

dgovil commented Nov 9, 2020

Looks good here! Thanks again for the quick turnaround.

@kxl-adsk kxl-adsk merged commit d67df19 into dev Nov 10, 2020
@kxl-adsk kxl-adsk deleted the t_gamaj/allow_unconnected_preview_surface branch November 10, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kxl-adsk kxl-adsk kxl-adsk approved these changes

Assignees

@ecp-maya-devops-adsk ecp-maya-devops-adsk

Labels
bug Something isn't working ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing input connections to a USD Preview Shader, deletes the shader as well
4 participants
@JGamache-autodesk @kxl-adsk @dgovil @ecp-maya-devops-adsk