Apply clang-format two more times to make sure we have everything formatted #918
Conversation
|
FYI @dgovil |
| MDagMessage::addInstanceRemovedDagPathCallback(bindNodeStringBoolFunc, | ||
| &cbi); */ | ||
| case DagMessage:: | ||
| kInstanceRemovedDagPath: /* cbi.mayaCallback = |
There was a problem hiding this comment.
This is pretty ugly...wasn't expecting clang-format to break it this way. Must have something to do with commented code after.
Something to remember and revisit eventually.
There was a problem hiding this comment.
Why not put it back to what it was before and use the clang-format off/on comment?
There was a problem hiding this comment.
I don't want developers to have to fallback to disabling clang-format in too many cases. We will update clang-format version at one point. This will be a good opportunity to revising some of the clang-format settings and prevent this type of formatting.
For that reason, I'm not going to use the clang-format off/on comment.
| // SdfValueTypeName TexCoord2hArray, TexCoord2fArray, TexCoord2dArray; | ||
| // SdfValueTypeName TexCoord3hArray, TexCoord3fArray, TexCoord3dArray; | ||
| }; | ||
| static const std::unordered_map<size_t, Ufe::Attribute::Type> sUsdTypeToUfe { |
There was a problem hiding this comment.
I really hate this formatting and this make it impossible to read. Can you please revert this map back to its original state before the first clang-format was applied. Then you can manually change the tabs to spaces. And add in the clang-format off/on comment so this block will remain unchanged by clang-format.
There was a problem hiding this comment.
Removed dead code and fixed based on our discussion.
| MDagMessage::addInstanceRemovedDagPathCallback(bindNodeStringBoolFunc, | ||
| &cbi); */ | ||
| case DagMessage:: | ||
| kInstanceRemovedDagPath: /* cbi.mayaCallback = |
There was a problem hiding this comment.
Why not put it back to what it was before and use the clang-format off/on comment?
kxl-adsk
deleted the
kxl-adsk/some_files_needed_clang_format_to_apply_twice
branch
After PR #890 we still had few files that weren't fully formatted by clang-format
For some reason, clang-format required to be applied twice to the above files (and to be precise, three times for lib/mayaUsd/ufe/UsdAttributes.cpp).
It's not something I was aware of, but luckily it's only these 4 files we missed.