Fix missing ARCH_CONSTRUCTOR code with VS2019 #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied verbatim from PixarAnimationStudios/OpenUSD@acf7c13
HamedSabri-adsk
approved these changes
Nov 20, 2020
cmake/compiler_config.cmake
Outdated
| else() | ||
| set(MSVC_FLAGS "${MSVC_FLAGS} /Zc:inline") | ||
| endif() | ||
|
|
There was a problem hiding this comment.
Nit-pick: You could also use regular expression to have you if/else logic in one line and keep it inside the MSVC_FLAGS list.
$<IF:$<VERSION_GREATER_EQUAL:${MSVC_VERSION},1920>,/Zc:inline-,/Zc:inline>
There was a problem hiding this comment.
That is a better syntax indeed. Thanks!
HamedSabri-adsk
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied verbatim from PixarAnimationStudios/OpenUSD@acf7c13