MAYA-106937 Prototype support for GPU Normals and OSD using glsl. #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abled by default.
huidong-chen
approved these changes
Dec 4, 2020
williamkrick
added
the
ready-for-merge
kxl-adsk
added
do-not-merge-yet
kxl-adsk
added
ready-for-merge
kxl-adsk
suggested changes
Dec 15, 2020
kxl-adsk
approved these changes
Dec 18, 2020
kxl-adsk
added
the
ready-for-merge
kxl-adsk
deleted the
krickw/MAYA-106937/prototype_compute_normals_and_OSD_on_the_gpu
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is disabled by default.
The GPU evaluation prototype is two separate parts, the normal calculation code and the OSD
code.
The normal calculation code is enabled by setting HDVP2_USE_GPU_NORMAL_COMPUTATION=1 at runtime.
The normal calculation code is close to being stable enough for general use, but hasn't had
enough polish to enable by default.
The OSD code requires the normal calculation code to be enabled to use. OSD is enabled
by compiling with HDVP2_ENABLE_GPU_OSD. The OSD code is much less stable then the normals
calculation code and comes with a number of huge.
OSD Limitations:
* No OSD adaptive support
* scenes with animation behave poorly
* selection in the viewport is very slow
* toggling VP2 consolidation world off and on will cause crashes
* some objects draw with incorrect indexing