fix: revoke-logins skips owner if owner is same as root #509 (#510)

Autodesk · Jul 10, 2024 · ed7e758 · ed7e758
1 parent b11c12a
commit ed7e758
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/pgbelt/cmd/login.py b/pgbelt/cmd/login.py
@@ -55,7 +55,12 @@ async def revoke_logins(config_future: Awaitable[DbupgradeConfig]) -> None:
             await _populate_logins(conf.src, pool, logger)
             save_task = asyncio.create_task(conf.save())
 
-        to_disable = [conf.src.owner_user.name]
+        to_disable = []
+        # Sometimes the owner user is the same as the root user.
+        # When that happens, we don't want to disable the owner user.
+        # If the owner user is different, we want to disable the owner user.
+        if conf.src.owner_user.name != conf.src.root_user.name:
+            to_disable.append(conf.src.owner_user.name)
 
         if conf.src.other_users is not None:
             to_disable += [

diff --git a/tests/integration/test_integration.py b/tests/integration/test_integration.py
@@ -12,8 +12,6 @@
 import pgbelt
 import pytest
 
-from typer import echo
-
 
 async def _check_status(
     configs: dict[str, DbupgradeConfig], src_dst_status: str, dst_src_status: str