Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QuickEditor: Remove backup rules from the Manifest #374

Closed
AdamGrzybkowski opened this issue Oct 9, 2024 · 0 comments · Fixed by #384
Closed

QuickEditor: Remove backup rules from the Manifest #374

AdamGrzybkowski opened this issue Oct 9, 2024 · 0 comments · Fixed by #384
Assignees
@AdamGrzybkowski
Labels
bug Something isn't working :gravatar-quickeditor Gravatar Quick Editor module
Milestone
2.0.0

Comments

@AdamGrzybkowski
Copy link
Contributor

Some apps that already have the token don't need anything from that, yet they might end up with Manifest merge conflicts because of that.
We shouldn't add those backup rules to the Manifest and just mention them in the docs.
@AdamGrzybkowski AdamGrzybkowski added :gravatar-quickeditor Gravatar Quick Editor module bug Something isn't working labels Oct 9, 2024
@AdamGrzybkowski AdamGrzybkowski added this to the 2.0.0 milestone Oct 9, 2024
@AdamGrzybkowski AdamGrzybkowski self-assigned this Oct 11, 2024
@AdamGrzybkowski AdamGrzybkowski mentioned this issue Oct 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdamGrzybkowski AdamGrzybkowski

Labels
bug Something isn't working :gravatar-quickeditor Gravatar Quick Editor module
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Remove backup rules from quickeditor manifest Automattic/Gravatar-SDK-Android
1 participant
@AdamGrzybkowski