Remove backup rules from quickeditor manifest #384
Merged
+7
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGrzybkowski
added
enhancement
📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
|
hamorillo
reviewed
Oct 11, 2024
hamorillo
approved these changes
Oct 11, 2024
AdamGrzybkowski
force-pushed
the
adam/374_backup_rules
branch
from
b79ea92
to
9c5eeb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #374
Description
Manifest merger failed when I tried to add QuickEditor in WP as they had their own backup rules applied. I'm not sure why the Merger ignores those rules in the Demo App (we also have them applied) but since this optional I think it's okey to remove them from the manifest.
Testing Steps
CI should be fine.