Add Github action: android.yml - gradle ktlint and build #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maxme
commented
Jan 16, 2024
maxme
commented
- Run on pull requests targetting trunk
- Run ./gradlew build
- Run ./gradlew ktlintcheck
|
I will wait for #18 to be merged to update that branch |
hamorillo
approved these changes
Jan 16, 2024
Comment on lines
+23
to
+24
| - name: Grant execute permission for gradlew | ||
| run: chmod +x gradlew |
There was a problem hiding this comment.
💡 I used this configuration in another project. You can find more info here. Maybe it could be useful to avoid manually changing permissions.
Suggested change
| - name: Grant execute permission for gradlew | |
| run: chmod +x gradlew | |
| - name: Setup Gradle | |
| uses: gradle/gradle-build-action@v2 |
There was a problem hiding this comment.
TBH I don't know what's best. I took thIs from the official "Android CI" action (thus the name ;)).
It might be useful to use the wrapper (gradlew) directly to find if there is any issue with it (like a wrong config, or a incorrect version), gradle-build-action states they cache the gradle binary, but that's not what takes the most time.
|
cc @gravatar/apps-infrastructure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.