Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Detekt for static code analysis #20

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Conversation

hamorillo
Copy link
Contributor

@hamorillo hamorillo commented Jan 17, 2024

Alt Text

Adding Detekt for static code analysis.

Detekt is also used in the WPAndroid repo, so, at the moment we are sharing the same custom rules.

Adding also the check to the GitHub actions in order to verify that everything looks good before merging a PR.

More info about possible configurations can be found here: https://detekt.dev/docs/gettingstarted/gradle/#options-for-detekt-configuration-closure

The tool is configured for both modules, app and library. It can be executed with the following commands:

./gradlew detekt
./gradlew :app:detekt
./gradlew :gravatar:detekt

Copy link
Contributor

@maxme maxme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@@ -0,0 +1,11 @@
package com.gravatar

object HttpResponseCode {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hamorillo hamorillo merged commit f4cc942 into trunk Jan 17, 2024
1 check passed
@hamorillo hamorillo deleted the hamorillo/13-detekt branch January 17, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants