Submit Gradle dependencies to GH dependency graph #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamorillo
reviewed
Jan 18, 2024
| with: | ||
| dependency-graph: generate-and-submit | ||
| - name: Generate the dependency graph which will be submitted post-job | ||
| run: ./gradlew :gravatar:dependencies |
There was a problem hiding this comment.
❓💡 We have to modules in this repo. The SDK itself. And a demo app that we are going to develop in parallel. Should we also add the demoApp dependencies?
./gradlew :app:dependencies
There was a problem hiding this comment.
Thanks, good question! I think we don't have to add dependencies of app module as this is only the sample app, not released to clients. Security vulnerabilities won't be a threat to the customers; hence I believe it's not worth to increase overhead of handling security vulnerabilities there 🙂.
hamorillo
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a GitHub Actions job to send Gradle/Maven dependencies to Github Dependency Graph for each push to
trunkorrelease/*branch.By sending those dependencies, we allow Dependabot to scan whether dependencies we use are affected by known vulnerabilities.
Soon, those metrics will be available to visualize on Apps Metrics (link).
More about this project can be found internally at paaHJt-5Tn-p2
I know
Gravatar-SDK-Androidis a small repository with not many dependencies at this point, but nevertheless I think it's worth collecting data and being informed about any security vulnerabilities as soon as possible.Testing instructions
This can't really be tested without forking, and forks are disabled for this repository.
This job is used in all other Android projects in Automattic, so it should be safe to merge without testing.