QuickEditor: Refreshing all info when no avatar selected and a new one is uploaded #381
Conversation
When a new avatar is uploaded into a Gravatar account with no avatar selected, the backend automatically uses that image as the default avatar. We need to reflect that in the QE UI. We can hardcode the changes in the code, modifying the uiState as required. However, if the backend behavior changes at some point, all previous versions of the QE will show the wrong status of the Gravatar account. To mitigate that situation, if an image is uploaded and no previous avatar is selected, we will refresh all data from the backend.
📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
|
| _uiState.update { AvatarPickerUiState(email, avatarPickerContentLayout) } | ||
| refresh() |
There was a problem hiding this comment.
I think it's completely reasonable to refresh the content like you said, to future proof in case of backend changes, but I wonder if we really have to clean the whole state?
Could we do this refresh action as part of the uploading indicator? With the current code, we hide the whole list, the profile card is recomposed fully and that seems like a lot to select an avatar.
There was a problem hiding this comment.
Could we do this refresh action as part of the uploading indicator? With the current code, we hide the whole list, the profile card is recomposed fully and that seems like a lot to select an avatar.
I don't think it's easy to keep the uploading indicator until the fetchAvatars finishes, at least reusing the current methods, but I'll try to improve it.
There was a problem hiding this comment.
Correct, you have to use suspend functions that won't start a new coroutine. We do have one like that to fetch avatars but not for the profile.
Closes #380
Description
When a new avatar is uploaded into a Gravatar account with no avatar selected, the backend automatically uses that image as the default avatar.
We need to reflect that in the QE UI. We can hardcode the changes in the code, modifying the uiState as required. However, if the backend behavior changes at some point, all previous versions of the QE will show the wrong status of the Gravatar account.
To mitigate that situation, we will refresh all data from the backend if an image is uploaded and no previous avatar is selected.
What do you think about this approach? Do you think it's worth it to refresh everything or assume the risk and modify the uiState locally, expecting the backend to do the same?
Note: I'll add some unit tests before merging if we decide to go this way.
Testing Steps