Skip to content

Commit

Permalink
Merge pull request #611 from Automattic/rebecca/cleanup_wpcs_warning_…
Browse files Browse the repository at this point in the history
…cruft

Removing cruft since it is already a warning in WordPress.WP.AlternativeFunctions.file_system_read
  • Loading branch information
rebeccahum authored Jan 9, 2021
2 parents 5d9cfb3 + 9ae891b commit 6d3f526
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions WordPress-VIP-Go/ruleset.xml
Original file line number Diff line number Diff line change
Expand Up @@ -114,11 +114,9 @@
-->
<!-- Should fix all of them but it doesn't need a manual review -->
<rule ref="WordPress.WP.AlternativeFunctions.file_system_read_fopen">
<type>warning</type>
<message>File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()` or `wp_get_upload_dir()` to get the proper directory path when using functions such as %s(). For more details, please see: https://wpvip.com/documentation/vip-go/writing-files-on-vip-go/</message>
</rule>
<rule ref="WordPress.WP.AlternativeFunctions.file_system_read_fclose">
<type>warning</type>
<message>File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()` or `wp_get_upload_dir()` to get the proper directory path when using functions such as %s(). For more details, please see: https://wpvip.com/documentation/vip-go/writing-files-on-vip-go/</message>
</rule>
<rule ref="WordPressVIPMinimum.Performance.FetchingRemoteData.FileGetContentsUnknown">
Expand Down

0 comments on commit 6d3f526

Please sign in to comment.