Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant error code WordPress.Security.EscapeOutput.OutputNotEscaped from WordPress-VIP-Go ruleset, as it is already being inherited from parent #606

Merged
merged 1 commit into from
Jan 9, 2021
Merged

Remove redundant error code WordPress.Security.EscapeOutput.OutputNotEscaped from WordPress-VIP-Go ruleset, as it is already being inherited from parent #606

merged 1 commit into from
Jan 9, 2021

Conversation

rebeccahum
Copy link
Contributor

Fixes #604.

@rebeccahum
WordPress.Security.EscapeOutput.OutputNotEscaped: Remove redundant er…
19ba9c8 
…ror code from WordPress-VIP-Go ruleset, as it is already being inherited from parent
@rebeccahum rebeccahum requested a review from a team as a code owner January 8, 2021 13:39
@rebeccahum
Copy link
Contributor Author

Hmmm...build failure seems unrelated to change:

There was 1 failure:
1) WordPressVIPMinimum\Tests\Variables\VariableAnalysisUnitTest::testSniff
[LINE 5] Expected 2 warning(s) in VariableAnalysisUnitTest.inc but found 1 warning(s). The warning(s) found were:
 -> Variable $b is undefined. (WordPressVIPMinimum.Variables.VariableAnalysis.UndefinedVariable)
/home/travis/build/Automattic/VIP-Coding-Standards/vendor/squizlabs/php_codesniffer/tests/Standards/AbstractSniffUnitTest.php:206
/home/travis/build/Automattic/VIP-Coding-Standards/vendor/squizlabs/php_codesniffer/tests/TestSuite.php:28

@GaryJones GaryJones added this to the 2.3.0 milestone Jan 9, 2021
@rebeccahum rebeccahum merged commit 5d9cfb3 into develop Jan 9, 2021
@rebeccahum rebeccahum deleted the rebecca/cleanup_604 branch January 9, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaryJones GaryJones GaryJones approved these changes

Assignees
No one assigned
Labels
Standard: VIP-Go
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

Remove redundant reference WordPress.Security.EscapeOutput.OutputNotEscaped in WordPress-VIP-Go ruleset
2 participants
@rebeccahum @GaryJones