Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning type since it inherits from parent as "warning" #617

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

rebeccahum
Copy link
Contributor

More cruft, similar to #611

@rebeccahum rebeccahum requested a review from a team as a code owner January 11, 2021 18:09
Copy link
Contributor

@GaryJones GaryJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is indeed added as a Warning in the sniff and not overridden in the WordPressVIPMinimum ruleset.

@rebeccahum rebeccahum merged commit d702c7b into develop Jan 12, 2021
@rebeccahum rebeccahum deleted the rebecca/remove_warning_cruft branch January 12, 2021 15:28
@jrfnl jrfnl added this to the 2.3.0 milestone Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants