Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdminBarRemovalUnitTest: Ensure final reset is read #737

Merged
merged 1 commit into from
Dec 21, 2022
Merged

AdminBarRemovalUnitTest: Ensure final reset is read #737

merged 1 commit into from
Dec 21, 2022

Conversation

GaryJones
Copy link
Contributor

The // phpcs:set comment should be a PHP comment, but the PHP opening delimiter was missing.

@GaryJones
AdminBarRemovalUnitTest: Ensure final reset is read
317db32 
The `// phpcs:set` comment should be a PHP comment, but the PHP opening delimiter was missing.
@GaryJones GaryJones added this to the 3.x milestone Dec 21, 2022
@GaryJones GaryJones requested a review from a team as a code owner December 21, 2022 00:26
@GaryJones GaryJones self-assigned this Dec 21, 2022
jrfnl
jrfnl approved these changes Dec 21, 2022
View reviewed changes
Copy link
Collaborator

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

Note: it is more common for the phpcs:set directives to use //-style than /* */-style, though IIRC, both should work.

Also, phpcs:set can be used in "inline HTML", just don't add comment markers in that case.

@GaryJones GaryJones merged commit b400608 into develop Dec 21, 2022
@GaryJones GaryJones deleted the fix/adminbarremoval-test branch December 21, 2022 14:15
@jrfnl jrfnl modified the milestones: 3.x, 2.3.4 Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrfnl jrfnl jrfnl approved these changes

Assignees

@GaryJones GaryJones

Labels
Type: Maintenance
Projects
None yet
Milestone
2.3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@GaryJones @jrfnl