Composer: update VariableAnalysis dependency #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this time, the minimum supported VA dependency is set at `2.11.1` after PR 691, which was included in VIPCS 2.3.3.
Since then, there have been a bunch of new releases. While the minimum supported version doesn't necessarily have to be updated each time, there is one reason why I believe it would be a good idea to update it:
* v 2.11.10 widened the allowed versions for the Composer PHPCS installer plugin.
Without this fix, the Composer plugin cannot update to v 1.0.0 as VA blocks the update.
And if we're updating VA anyway, I suggest we go straight to the latest & greatest as quite a few bugs, most to do with modern PHP support, have been fixed in the mean time.
Refs: https://github.com/sirbrillig/phpcs-variable-analysis/releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this time, the minimum supported VA dependency is set at
2.11.1after PR #691, which was included in VIPCS 2.3.3.Since then, there have been a bunch of new releases. While the minimum supported version doesn't necessarily have to be updated each time, there is one reason why I believe it would be a good idea to update it:
And if we're updating VA anyway, I suggest we go straight to the latest & greatest as quite a few bugs, most to do with modern PHP support, have been fixed in the mean time.
Refs: https://github.com/sirbrillig/phpcs-variable-analysis/releases