Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text domains #39

Merged
merged 3 commits into from
Mar 6, 2020
Merged

Add text domains #39

merged 3 commits into from
Mar 6, 2020

Conversation

akirk
Copy link
Member

@akirk akirk commented Mar 5, 2020

For loading translations of Gutenberg blocks, we need to specify the text domain with the WordPress.org plugin slug being the correct domain.

This adds the text domain for the following plugins we have on .org:

This also adds the missing wp_set_script_translations() calls to actually load the translations from the language pack.

@johngodley
Copy link
Member

Works well, merging.

@johngodley johngodley merged commit 761a81f into master Mar 6, 2020
@johngodley johngodley deleted the add/text-domains branch March 6, 2020 09:32
@akirk
Copy link
Member Author

akirk commented Mar 6, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants