Skip to content
Linting

Block Theme Previews: show education modal when previewing theme #49916

Sign in to view logs

Block Theme Previews: show education modal when previewing theme

Block Theme Previews: show education modal when previewing theme #49916

Triggered via pull request January 10, 2024 12:59
@fusharfushar
opened #34935
live-preview-modal
Status Failure
Total duration 4m 3s
Artifacts –

linting.yml

on: pull_request
detect changed files
10s
detect changed files
Copied files are in sync
6s
Copied files are in sync
Changelogger use
25s
Changelogger use
Changelogger validity
53s
Changelogger validity
Project structure
2m 40s
Project structure
PHP Code Sniffer (non-excluded files only)
1m 31s
PHP Code Sniffer (non-excluded files only)
PHP Compatibility
1m 10s
PHP Compatibility
PHP Code Sniffer (changes to excluded files only)
0s
PHP Code Sniffer (changes to excluded files only)
ESLint (non-excluded files only)
3m 33s
ESLint (non-excluded files only)
ESLint (changes to excluded files only)
0s
ESLint (changes to excluded files only)
Lint GitHub Actions yaml files
0s
Lint GitHub Actions yaml files
Check linter exclude lists
3m 9s
Check linter exclude lists
Lock files are up to date
2m 24s
Lock files are up to date
Monorepo package version refs
2m 40s
Monorepo package version refs
Matrix: php_lint
Fit to window
Zoom out
Zoom in

Annotations

7 errors and 5 warnings
Changelogger validity: projects/packages/jetpack-mu-wpcom/package.json#L4
Version mismatch, expected 5.9.0-alpha but found 5.8.2-alpha! You might use `tools/project-version.sh -f -u 5.9.0-alpha packages/jetpack-mu-wpcom` or `tools/fixup-project-versions.sh` to fix this.
Changelogger validity: projects/packages/jetpack-mu-wpcom/composer.json#L52
Version mismatch, expected 5.9.x-dev but found 5.8.x-dev! You might use `tools/project-version.sh -f -u 5.9.0-alpha packages/jetpack-mu-wpcom` or `tools/fixup-project-versions.sh` to fix this.
Changelogger validity: projects/packages/jetpack-mu-wpcom/src/class-jetpack-mu-wpcom.php#L17
Version mismatch, expected 5.9.0-alpha but found 5.8.2-alpha! You might use `tools/project-version.sh -f -u 5.9.0-alpha packages/jetpack-mu-wpcom` or `tools/fixup-project-versions.sh` to fix this.
Changelogger validity
Process completed with exit code 1.
PHP Code Sniffer (non-excluded files only): projects/packages/jetpack-mu-wpcom/src/features/block-theme-previews/block-theme-previews.php#L23
Missing doc comment for function wpcom_enqueue_block_theme_previews_assets() (Squiz.Commenting.FunctionComment.Missing)
PHP Code Sniffer (non-excluded files only)
Process completed with exit code 2.
ESLint (non-excluded files only)
Process completed with exit code 1.
PHP Code Sniffer (non-excluded files only): projects/packages/jetpack-mu-wpcom/src/features/block-theme-previews/block-theme-previews.php#L8
Found precision alignment of 1 spaces. (Universal.WhiteSpace.PrecisionAlignment.Found)
PHP Code Sniffer (non-excluded files only): projects/packages/jetpack-mu-wpcom/src/features/block-theme-previews/block-theme-previews.php#L25
Unused variable $dependencies. (VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable)
PHP Code Sniffer (non-excluded files only): projects/packages/jetpack-mu-wpcom/src/features/block-theme-previews/block-theme-previews.php#L26
Unused variable $version. (VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable)
ESLint (non-excluded files only): projects/packages/jetpack-mu-wpcom/src/features/block-theme-previews/modal.tsx#L8
Missing JSDoc block description
ESLint (non-excluded files only): projects/packages/jetpack-mu-wpcom/src/features/block-theme-previews/modal.tsx#L8
Missing JSDoc @returns declaration