Launchpad: Add validation for required tasks (#31626)

* [not verified] Check that all required tasks are included in the array of task ids * changelog * [not verified] Compare the arrays, don't count them * the condition was wrong --------- Co-authored-by: Andrés Blanco <[email protected]>
Automattic · Jul 3, 2023 · d4b9a58 · d4b9a58
1 parent 637c4a8
commit d4b9a58
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/projects/packages/jetpack-mu-wpcom/changelog/add-required-tasks-validation b/projects/packages/jetpack-mu-wpcom/changelog/add-required-tasks-validation
@@ -0,0 +1,4 @@
+Significance: minor
+Type: added
+
+Add validation for required tasks.
diff --git a/projects/packages/jetpack-mu-wpcom/src/features/launchpad/class-launchpad-task-lists.php b/projects/packages/jetpack-mu-wpcom/src/features/launchpad/class-launchpad-task-lists.php
@@ -434,6 +434,12 @@ public static function validate_task_list( $task_list ) {
 			return false;
 		}
 
+		// If we have required tasks, make sure they all exist in the array of `task_ids`.
+		if ( isset( $task_list['required_task_ids'] ) && array_intersect( $task_list['required_task_ids'], $task_list['task_ids'] ) !== $task_list['required_task_ids'] ) {
+			_doing_it_wrong( 'validate_task_list', 'The required_task_ids must be a subset of the task_ids', '6.1' );
+			return false;
+		}
+
 		if ( isset( $task_list['require_last_task_completion'] ) && ! is_bool( $task_list['require_last_task_completion'] ) ) {
 			_doing_it_wrong( 'validate_task_list', 'The require_last_task_completion attribute must be a boolean', '6.1' );
 			return false;