Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing Block: switch new block to production #34324

Closed
Tracked by #19694
jeherve opened this issue Nov 28, 2023 · 4 comments · Fixed by #34553
Closed
Tracked by #19694

Sharing Block: switch new block to production #34324

jeherve opened this issue Nov 28, 2023 · 4 comments · Fixed by #34553
Assignees
@andrii-lysenko
Labels
[Block] Sharing Buttons [Feature] Sharing Post sharing, sharing buttons [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@jeherve
Copy link
Member

jeherve commented Nov 28, 2023 •
edited
Loading

Epic: #19694.
@jeherve jeherve mentioned this issue Nov 28, 2023
Closed
5 tasks
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Sharing Post sharing, sharing buttons [Pri] Normal [Block] Sharing Buttons labels Nov 28, 2023
@chrisbliss18
Copy link
Contributor

Ensure that we communicate this change to Garage to ensure that testing is added.

@andrii-lysenko
Copy link
Contributor

andrii-lysenko commented Dec 6, 2023 •
edited
Loading

@jeherve @chrisbliss18 maybe we will first roll these out as Experimental, what do you think? Or prod but adding (Experimental) to the name?

@andrii-lysenko andrii-lysenko mentioned this issue Dec 7, 2023
Closed
3 tasks
@jeherve
Copy link
Member Author

jeherve commented Dec 7, 2023

I'd go with production out of the box, as soon as the block is ready.

@andrii-lysenko andrii-lysenko mentioned this issue Dec 8, 2023
Merged
3 tasks
@andrii-lysenko
Copy link
Contributor

We are holding off on this until we are done with Call For Testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrii-lysenko andrii-lysenko

Labels
[Block] Sharing Buttons [Feature] Sharing Post sharing, sharing buttons [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sharing block production ready Automattic/jetpack
3 participants
@chrisbliss18 @jeherve @andrii-lysenko