Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing: create a "Sharing Buttons" block #19694

Closed
21 tasks done
Tracked by #31920
andrewserong opened this issue Apr 29, 2021 · 7 comments
Closed
21 tasks done
Tracked by #31920

Sharing: create a "Sharing Buttons" block #19694

andrewserong opened this issue Apr 29, 2021 · 7 comments
Assignees
Labels
[Block] Sharing Button [Block] Sharing Buttons Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". Epic Formerly "Primary Issue", or "Master Issue" [Feature] Sharing Post sharing, sharing buttons [Focus] FSE Issues related to the site editor / Full Site Editing / FSE feature in Gutenberg [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@andrewserong
Copy link
Member

andrewserong commented Apr 29, 2021

Related Epic: #31920

Related to #19659 (essentially the same task for the Like button feature)

This issue is to implement a simple MVP server side rendering block for the "Share this" feature that gets automatically appended to the end of post content. Ideally in full site editing, a user should be able to place this feature where they like within a template part.

As an example, the below screenshot is a mock up of moving out the Like button feature to a Footer template part. Here, it's clear that it would be good for the user to also be able to place the "Share this" feature elsewhere within the page:

image

Tasks

  • Create a block for the Sharing feature (and come up with a clear name for it)
    • In the editor, use a static approximation of the feature
    • On the front end, add a server side render_block method that calls the existing sharing_display method
  • If an FSE theme is active, prevent the automatic sharing_display from appending the "Share this" feature to post content (it's registered against the_content filter here, and the logic lives here )
  • Ensure the existing settings to hide the sharing feature on an individual post or globally, still applies to the block version

Tasks

  1. [Block] Sharing Buttons [Feature] Sharing [Type] Enhancement
    andrii-lysenko
  2. [Block] Sharing Buttons [Plugin] Jetpack
  3. [Block] Sharing Buttons [Feature] Sharing [Focus] Performance [Pri] Normal [Type] Enhancement
    andrii-lysenko
  4. [Block] Sharing Buttons [Feature] Sharing [Type] Enhancement
    andrii-lysenko
  5. [Block] Sharing Buttons [Feature] Sharing [Type] Enhancement
    andrii-lysenko
  6. [Block] Sharing Buttons [Feature] Sharing [Pri] Normal [Type] Enhancement
    andrii-lysenko
  7. Admin Page Customer Report [Block] Sharing Buttons [Feature] Sharing [Focus] Blocks [Focus] FSE [Pri] Normal [Status] Needs Design [Type] Enhancement
    andrii-lysenko jeherve
  8. [Feature] Sharing [Focus] FSE [Pri] Normal [Status] In Progress [Type] Enhancement
    andrii-lysenko jeherve
  9. [Feature] Sharing [Focus] FSE [Pri] Normal [Type] Enhancement
    andrii-lysenko
  10. [Block] Sharing Button [Feature] Sharing
    andrii-lysenko
  11. [Block] Sharing Buttons [Feature] Sharing [Focus] Blocks
    andrii-lysenko
  12. [Block] Sharing Buttons [Feature] Sharing [Focus] Blocks [Focus] Performance
    andrii-lysenko
  13. [Block] Sharing Button [Block] Sharing Buttons [Feature] Sharing
    andrii-lysenko
  14. 7 of 7
    [Block] Sharing Button [Block] Sharing Buttons [Feature] Sharing [Type] Enhancement
  15. Customer Report [Block] Sharing Button [Block] Sharing Buttons [Feature] Sharing [Focus] Blocks
    andrii-lysenko
  16. Customer Report [Block] Sharing Button [Block] Sharing Buttons [Feature] Sharing [Focus] Blocks
    andrii-lysenko
  17. Customer Report [Block] Sharing Button [Block] Sharing Buttons [Feature] Sharing [Focus] Blocks
    andrii-lysenko
  18. [Block] Sharing Button [Block] Sharing Buttons [Plugin] Jetpack [Type] Enhancement
    andrii-lysenko
  19. [Block] Sharing Button [Block] Sharing Buttons [Feature] Sharing [Pri] Normal [Type] Enhancement
    jeherve
  20. [Block] Sharing Buttons [Feature] Earn Blocks [Feature] Sharing [Focus] Blocks
    andrii-lysenko
  21. [Block] Sharing Button [Block] Sharing Buttons [Feature] Sharing [Pri] Low [Type] Bug
    andrii-lysenko
@jeherve
Copy link
Member

jeherve commented Feb 4, 2022

Also in pdHDFB-8-p2

@jeherve jeherve added the [Focus] FSE Issues related to the site editor / Full Site Editing / FSE feature in Gutenberg label Jul 29, 2022
@lakellie
Copy link

Just noting that we had a user contact us requesting this functionality in 5648078-zen

@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Oct 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2022

Support References

This comment is automatically generated. Please do not edit it.

  • 5648078-zen
  • 6169722-zen
  • 7148193-zen

@jeherve
Copy link
Member

jeherve commented Jan 26, 2023

Also suggested in pdHDFB-m-p2

@thekingsprojects
Copy link

Had a user confused by the lack of sharing buttons in their Query Loop block, expecting them to be available there: 6169722-zen

@jeherve jeherve added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal labels Aug 7, 2023
@jeherve jeherve self-assigned this Oct 10, 2023
@Aurorum
Copy link
Contributor

Aurorum commented Oct 12, 2023

Came up in 7148193-zen

@jeherve
Copy link
Member

jeherve commented Feb 27, 2024

Marking this as done. We'll iterate on this block in #35993.

@jeherve jeherve closed this as completed Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Sharing Button [Block] Sharing Buttons Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". Epic Formerly "Primary Issue", or "Master Issue" [Feature] Sharing Post sharing, sharing buttons [Focus] FSE Issues related to the site editor / Full Site Editing / FSE feature in Gutenberg [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
No open projects
Status: To do
Development

No branches or pull requests

7 participants