Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blaze: use translated post type name in post-publish panel #31399

Merged
merged 4 commits into from
Jun 23, 2023

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Jun 15, 2023

Proposed changes:

Instead of relying on the raw post type slug, let's pull the translated post type label. We need to ensure it is lowercase, since it's used in a sentence.

Before After
Screenshot 2023-06-15 at 14 37 03 Screenshot 2023-06-15 at 14 40 42

Note
In the French translation above, I had to move the non-translated post type name at the end of the string, where it looked less worse standing on its own. Once this fix is merged and shipped, I will be able to update the translated string again to form a proper sentence without parenthesis.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Go to Settings > General, and switch your site language to French.
  • Go to Dashboard > Updates, and update translations if necessary.
  • Go to Posts > Add New, write a new post.
  • Publish your post.
  • View the post-publish panel and its Blaze section; the post type name should be translated.

Instead of relying on the raw post type slug, let's pull the translated post type label. We need to ensure it is lowercase, since it's used in a sentence.
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Focus] i18n Internationalization / i18n, adaptation to different languages [Pri] Normal [Extension] Blaze [Package] Blaze labels Jun 15, 2023
@jeherve jeherve self-assigned this Jun 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack plugin. Once the plugin is active, go to Jetpack > Jetpack Beta > Jetpack and enable the fix/blaze-post-publish-i18n branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/blaze-post-publish-i18n
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@github-actions github-actions bot added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jun 15, 2023
@jeherve jeherve added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jun 15, 2023
@samiff samiff added this to the jetpack/12.3 milestone Jun 21, 2023
samiff
samiff previously approved these changes Jun 22, 2023
@samiff samiff added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jun 22, 2023
@jeherve
Copy link
Member Author

jeherve commented Jun 23, 2023

I had to update with latest trunk after merging another PR, so this will need another approval I'm afraid.
Thank you!

@jeherve jeherve added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jun 23, 2023
@jeherve jeherve enabled auto-merge (squash) June 23, 2023 08:08
@jeherve jeherve merged commit 3b92978 into trunk Jun 23, 2023
@jeherve jeherve deleted the fix/blaze-post-publish-i18n branch June 23, 2023 16:34
@github-actions github-actions bot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Extension] Blaze [Focus] i18n Internationalization / i18n, adaptation to different languages [Package] Blaze [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants