-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update postcss-loader configs #31583
Conversation
A few years ago postcss-loader added the ability to specify plugins as an array of plugin objects rather than as an object mapping plugin names to configs. Taking advantage of this lets us not have to use `NODE_PATH` for webpack invocations all over the place to allow postcss-loader to find its plugins.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
Social plugin:
Crm plugin:
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, I have tested the affected plugins: builds seem to be working fine, the plugins themselves look fine on the site too.
Proposed changes:
A few years ago postcss-loader added the ability to specify plugins as an array of plugin objects rather than as an object mapping plugin names to configs.
Taking advantage of this lets us not have to use
NODE_PATH
for webpack invocations all over the place to allow postcss-loader to find its plugins.Other information:
Jetpack product discussion
None
Does this pull request change what data or activity we track or use?
No
Testing instructions: