Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats Admin: site plan and products #31663

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Conversation

kangzj
Copy link
Contributor

@kangzj kangzj commented Jul 3, 2023

Fixes #31477

Proposed changes:

The PR adds plan and products support for Odyssey, which allow Odyssey to determine whether the site has valid plan for Stats.

  • Adds config.intial_state.sites.items.${site_id}.plan
  • Adds config.intial_state.sites.items.${site_id}.products

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • Build the branch for Odyssey
    • STATS_PACKAGE_PATH=~/path/to/jetpack/projects/packages/stats-admin yarn dev
  • Build Jetpack if necessary
    • jetpack build plugins/jetpack
  • Open /wp-admin/admin.php?page=stats
  • Open dev console
  • Ensure config.intial_state.sites.items.${site_id}.plan and config.intial_state.sites.items.${site_id}.products
    have all the values in the screenshot

Image

@kangzj kangzj added [Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. [Package] Stats Admin labels Jul 3, 2023
@kangzj kangzj self-assigned this Jul 3, 2023
@kangzj kangzj requested a review from a team July 3, 2023 04:20
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack plugin. Once the plugin is active, go to Jetpack > Jetpack Beta > Jetpack and enable the add/odyssey-site-plan-products branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/odyssey-site-plan-products
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

  • Next scheduled release: July 5, 2023.
  • Scheduled code freeze: June 26, 2023.

@kangzj kangzj marked this pull request as ready for review July 3, 2023 23:17
@kangzj kangzj force-pushed the add/odyssey-site-plan-products branch from 66a0f47 to 93b9231 Compare July 3, 2023 23:21
@kangzj kangzj requested a review from dognose24 July 3, 2023 23:21
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jul 3, 2023
Copy link
Contributor

@dognose24 dognose24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described!

@kangzj kangzj merged commit 591e06f into trunk Jul 4, 2023
51 of 54 checks passed
@kangzj kangzj deleted the add/odyssey-site-plan-products branch July 4, 2023 03:42
@github-actions github-actions bot added this to the jetpack/12.3 milestone Jul 4, 2023
@samiff samiff modified the milestones: jetpack/12.3, jetpack/12.4 Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. [Package] Stats Admin [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paid Stats: Add purchase status support to Odyssey
3 participants