Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAL: Add wpcom_site_setup property to /sites/{siteId} endpoint #31664

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

miksansegundo
Copy link
Contributor

@miksansegundo miksansegundo commented Jul 3, 2023

Related #31662 Automattic/wp-calypso#78852

Proposed changes:

  • Add wpcom_site_setup property to /sites/{siteId} endpoint

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Sandbox the API
  • Make a request to /sites/{siteId}
  • Verify the response contains the property wpcom_site_setup in options
    • The value will be false if it's not set, or can be assembler if you are reusing that site

Tested on a Simple site

Screenshot 2566-07-03 at 14 42 21 Screenshot 2566-07-03 at 14 36 34

Tested on an Atomic site

Screenshot 2566-07-03 at 15 06 02

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack plugin. Once the plugin is active, go to Jetpack > Jetpack Beta > Jetpack and enable the add/wpcom-site-setup-to-sites-endpoint branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/wpcom-site-setup-to-sites-endpoint
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Feature] WPCOM API labels Jul 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

  • Next scheduled release: July 5, 2023.
  • Scheduled code freeze: June 26, 2023.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jul 3, 2023
@miksansegundo miksansegundo added [Status] Needs Team Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jul 3, 2023
@miksansegundo
Copy link
Contributor Author

The e2e tests that are failing are not related to my changes. See p1686869270217619-slack-CBG1CP4EN

@miksansegundo
Copy link
Contributor Author

The continuous-integration/a8c-teamcity test failing in D115123-code is also unrelated to my changes.

Screenshot 2566-07-03 at 15 09 20

@miksansegundo
Copy link
Contributor Author

@Automattic/lego can you review these changes, please?

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Team Review labels Jul 3, 2023
@miksansegundo miksansegundo merged commit 59d50f4 into trunk Jul 4, 2023
55 of 56 checks passed
@miksansegundo miksansegundo deleted the add/wpcom-site-setup-to-sites-endpoint branch July 4, 2023 05:11
@github-actions github-actions bot added this to the jetpack/12.3 milestone Jul 4, 2023
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jul 4, 2023
@samiff samiff modified the milestones: jetpack/12.3, jetpack/12.4 Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] WPCOM API [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants