Transfer Verbum app into into jetpack-mu-wpcom #34993

agrullon95 · 2024-01-12T16:45:32Z

Proposed changes:

Moves Verbum Comments project into Jetpack mu wpcom plugin. It also has some glue code to handle the transition between the deployed and the upcoming versions.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Does this pull request change what data or activity we track or use?

Not at all.

Testing instructions:

Navigate to projects/packages/jetpack-mu-wpcom
Run pnpm run build-js to build Verbum (development) or Run npm run build-production-js (production)
Run jetpack rsync jetpack mu-wpcom-plugin and select your sandbox as the destination (full command example jetpack rsync mu-wpcom-plugin user@hostname:~/public_html/wp-content/mu-plugins/jetpack-mu-wpcom-plugin/production
Make sure you have set define( 'JETPACK_AUTOLOAD_DEV', true ); in a mu-plugin/0-sandbox.php.
On WPCOM, modify comment-experience-loader.php and make load_verbum_comments return early.
The comment experience should continue to function, and it should be Verbum (not Highlander or core's).
Verify further that the new experience is in charge by checking the path of the verbum-comment.js bundle in Network tab.
Try your best to break the comment experience. Comment as a guest, comment from Atomic, and log in using FB.

github-actions · 2024-01-12T16:46:29Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Mu Wpcom plugin:

Next scheduled release: February 6, 2024.
Scheduled code freeze: January 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions · 2024-01-12T16:47:11Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/verbum-comment-into-jetpack-mu-wpcom branch.
- For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack add/verbum-comment-into-jetpack-mu-wpcom

bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/verbum-comment-into-jetpack-mu-wpcom

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

agrullon95 · 2024-01-12T16:57:39Z

projects/packages/jetpack-mu-wpcom/webpack.config.js

+			h: [ 'preact', 'h' ],
+			Fragment: [ 'preact', 'Fragment' ],
+		} ),
+		new CopyPlugin( {


Copies Verbum php files into build/verbum-comments folder.

agrullon95 · 2024-01-12T16:58:32Z

projects/packages/jetpack-mu-wpcom/webpack.config.js

@@ -34,7 +58,10 @@ module.exports = {
 			} ),

 			// Handle CSS.
-			jetpackConfig.CssRule(),
+			jetpackConfig.CssRule( {
+				extensions: [ 'css', 'sass', 'scss' ],


Handles scss conversion to css

agrullon95 · 2024-01-12T16:59:59Z

projects/packages/jetpack-mu-wpcom/webpack.config.js

+	plugins: [
+		...jetpackConfig.StandardPlugins( {
+			DependencyExtractionPlugin: { injectPolyfill: true },
+			MiniCssExtractPlugin: { filename: '[name]/[name].css' },


Outputs CSS in the same build directory as the entry.

For Verbum, css will output in build/verbum-comments.

agrullon95 · 2024-01-12T17:04:34Z

projects/packages/jetpack-mu-wpcom/babel.config.json

+{
+	"plugins": [
+		[
+			"@babel/plugin-transform-react-jsx",


Converts JSX to react function calls.

Example
-> React.createElement("div", null, "Example");

…loaded in WPCOM

projects/packages/jetpack-mu-wpcom/src/features/verbum-comments/vite.config.ts

projects/packages/jetpack-mu-wpcom/src/features/verbum-comments/src/utils.ts

...packages/jetpack-mu-wpcom/src/features/verbum-comments/src/components/editor-placeholder.tsx

agrullon95 · 2024-01-13T19:30:16Z

projects/packages/jetpack-mu-wpcom/src/class-jetpack-mu-wpcom.php

+	 * Load Verbum Comments.
+	 */
+	public static function load_verbum_comments() {
+		if ( class_exists( 'Verbum_Comments' ) ) {


class_exists condition will be removed when this is finalized, merged into WPCOM, removed from mu-plugins/verbum and we're ready to transfer over to Verbum_Comments inside of jetpack-mu-wpcom plugin.

heavyweight · 2024-01-22T14:17:54Z

projects/packages/jetpack-mu-wpcom/src/features/verbum-comments/src/utils.ts

+ */
+export function isFastConnection() {
+	// Hardcoding the size of the bundle.
+	const bytes = 30000;


prod build is 232kb for me and 51.6kb are transferred in the networks tab.
how do we plan to manage this value?

We don't have a solution for calculating and setting this value as of now.
I removed my initial solution since it wouldn't be efficient enough. However, we still need to figure out a way to either calculate this value or another method to determine what a "fast connection" would be.

51.6kb are transferred in the networks tab.

I see 51.3kb transferred if I use the dev build and 29.5kb with the production build.
Can you check again?

I'm getting the same now

agrullon95 · 2024-01-22T17:19:23Z

Hey @fushar can you please smoke test the block-theme-previews feature? I see that you recently added it to jetpack-mu-wpcom. We made a few changes to the webpack config and want to ensure we don't cause issues in your code. Thanks!

heavyweight

When clicking "continue reading" I get this. This looks like a regression

heavyweight · 2024-01-22T17:27:17Z

also reproducible by writing a comment, logging in with facebook and clicking "Reply"

agrullon95 · 2024-01-22T17:54:50Z

@heavyweight

When clicking "continue reading" I get this. This looks like a regression

I'm taking a look at these issues

daledupreez · 2024-01-22T18:56:12Z

Hi @daledupreez! Would you mind taking error-reporting for a smoke test? We changed the webpack config and I'm trying to make sure things are working well.

@fullofcaffeine, could you take a look at this? I honestly don't know how to fully test the error-reporting logic!

agrullon95 · 2024-01-23T01:19:31Z

@heavyweight - I pushed a change to fix the logic when you click outside of the Subscription modal

fushar · 2024-01-23T04:55:00Z

Hey @fushar can you please smoke test the block-theme-previews feature?

Thanks for the ping! I tested on Simple and the feature looks broken now:

I don't have the bandwidth to investigate this, could you help? All information should be available in this PR, the only PR that introduced the feature:

Block Theme Previews: show education modal when previewing theme #34935

heavyweight · 2024-01-23T06:53:02Z

Hey @fushar can you please smoke test the block-theme-previews feature?

Thanks for the ping! I tested on Simple and the feature looks broken now:
I don't have the bandwidth to investigate this, could you help? All information should be available in this PR, the only PR that introduced the feature:

Block Theme Previews: show education modal when previewing theme #34935

Thanks for taking the time.
We will take a look at this

heavyweight · 2024-01-23T06:59:58Z

@heavyweight - I pushed a change to fix the logic when you click outside of the Subscription modal

Checked and works great!

heavyweight

LGTM

daledupreez · 2024-01-25T12:43:04Z

projects/packages/jetpack-mu-wpcom/src/class-jetpack-mu-wpcom.php

+	 * @return boolean
+	 */
+	private function should_disable_comment_experience( $blog_id ) {
+		require_once WP_CONTENT_DIR . '/lib/wpforteams/functions.php';


Thought: this is going to fail on Atomic sites, as this code only exists on WordPress.com Simple. Or did we already verify that it will work?

You're right, it did fail on Atomic sites, leading to the revert in #35194. The second attempt at this in #35196 (specifically e89db35) both added a check before the require and added a check to only register the action that calls this method on Simple.

agrullon95 added 2 commits January 11, 2024 17:26

Add Verbum Comments in Jetpack-mu-wpcom

40dc407

changelog

67760a1

agrullon95 self-assigned this Jan 12, 2024

github-actions bot added [Package] Jetpack mu wpcom WordPress.com Features [Status] In Progress labels Jan 12, 2024

agrullon95 commented Jan 12, 2024

View reviewed changes

agrullon95 added 3 commits January 13, 2024 13:46

Add dynamic import support to webpack config

88a257d

Add logi to load new Jetpack Verbum Comment class if its not already …

39570ea

…loaded in WPCOM

Add Verbum Comments project into jetpack-mu-wpcom features directory

b88da1c

github-actions bot added [Tests] Includes Tests Docs [mu wpcom Feature] Verbum Comments Verbum, a better comment experience, app developed in the mu-wpcom plugin labels Jan 13, 2024

Remove Verbum editor folder since it will be loaded from new package

b9bbdf3

agrullon95 commented Jan 13, 2024

View reviewed changes

projects/packages/jetpack-mu-wpcom/src/features/verbum-comments/vite.config.ts Outdated Show resolved Hide resolved

agrullon95 commented Jan 13, 2024

View reviewed changes

projects/packages/jetpack-mu-wpcom/src/features/verbum-comments/src/utils.ts Outdated Show resolved Hide resolved

agrullon95 commented Jan 13, 2024

View reviewed changes

...packages/jetpack-mu-wpcom/src/features/verbum-comments/src/components/editor-placeholder.tsx Show resolved Hide resolved

agrullon95 commented Jan 13, 2024

View reviewed changes

agrullon95 requested review from escapemanuele, renancarvalho, alshakero and heavyweight January 13, 2024 19:31

agrullon95 changed the title ~~Add/verbum comment into jetpack mu wpcom~~ Add/verbum comment into jetpack mu wpcom [DO NOT MERGE] Jan 13, 2024

agrullon95 added the DO NOT MERGE don't merge it! label Jan 13, 2024

agrullon95 added 2 commits January 16, 2024 21:01

Add plugin to replace verbumBundleSize global variable value

0e1f43e

Use GetVerbumBundleSizePlugin in webpack config

43a797f

heavyweight reviewed Jan 22, 2024

View reviewed changes

Update beforeunload logic

925423c

agrullon95 dismissed alshakero’s stale review via 925423c January 22, 2024 19:25

agrullon95 and others added 4 commits January 22, 2024 14:27

Move handleClose function order

d9178e7

Update event dispose logic

557dbc7

Merge branch 'trunk' into add/verbum-comment-into-jetpack-mu-wpcom

c0aed72

update package version

0af3b26

github-actions bot added the [Plugin] mu wpcom jetpack-mu-wpcom plugin label Jan 22, 2024

agrullon95 added 2 commits January 22, 2024 20:10

Fix subscription closeModalHandlercommentUrl issue

c64dc3c

Merge branch 'trunk' into add/verbum-comment-into-jetpack-mu-wpcom

70551b8

alshakero added 3 commits January 23, 2024 12:09

Dont touch babel and webpack config for other projects

69dd842

Exclude P2 and forums from Verbum

8f0e01f

Merge branch 'trunk' into add/verbum-comment-into-jetpack-mu-wpcom

f0eedd1

heavyweight approved these changes Jan 23, 2024

View reviewed changes

alshakero merged commit f5139c0 into trunk Jan 23, 2024
66 checks passed

alshakero deleted the add/verbum-comment-into-jetpack-mu-wpcom branch January 23, 2024 13:17

github-actions bot removed the [Status] In Progress label Jan 23, 2024

anomiex mentioned this pull request Jan 23, 2024

Revert "Transfer Verbum app into into jetpack-mu-wpcom" #35194

Merged

heavyweight restored the add/verbum-comment-into-jetpack-mu-wpcom branch January 23, 2024 15:02

daledupreez reviewed Jan 25, 2024

View reviewed changes

anomiex mentioned this pull request Oct 3, 2024

Use DEWP's new auto-wp-polyfill support #39629

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Transfer Verbum app into into jetpack-mu-wpcom #34993

Transfer Verbum app into into jetpack-mu-wpcom #34993

agrullon95 commented Jan 12, 2024 •

edited by alshakero

Loading

github-actions bot commented Jan 12, 2024 •

edited

Loading

github-actions bot commented Jan 12, 2024 •

edited

Loading

agrullon95 Jan 12, 2024

agrullon95 Jan 12, 2024 •

edited

Loading

agrullon95 Jan 12, 2024

agrullon95 Jan 12, 2024

agrullon95 Jan 13, 2024

heavyweight Jan 22, 2024

agrullon95 Jan 22, 2024

agrullon95 Jan 22, 2024 •

edited

Loading

heavyweight Jan 22, 2024

agrullon95 commented Jan 22, 2024

heavyweight left a comment

heavyweight commented Jan 22, 2024

agrullon95 commented Jan 22, 2024

daledupreez commented Jan 22, 2024

agrullon95 commented Jan 23, 2024

fushar commented Jan 23, 2024

heavyweight commented Jan 23, 2024

heavyweight commented Jan 23, 2024

heavyweight left a comment

daledupreez Jan 25, 2024

anomiex Jan 25, 2024

Transfer Verbum app into into jetpack-mu-wpcom #34993

Transfer Verbum app into into jetpack-mu-wpcom #34993

Conversation

agrullon95 commented Jan 12, 2024 • edited by alshakero Loading

Proposed changes:

Other information:

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Jan 12, 2024 • edited Loading

github-actions bot commented Jan 12, 2024 • edited Loading

Choose a reason for hiding this comment

agrullon95 Jan 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agrullon95 Jan 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agrullon95 commented Jan 22, 2024

heavyweight left a comment

Choose a reason for hiding this comment

heavyweight commented Jan 22, 2024

agrullon95 commented Jan 22, 2024

daledupreez commented Jan 22, 2024

agrullon95 commented Jan 23, 2024

fushar commented Jan 23, 2024

heavyweight commented Jan 23, 2024

heavyweight commented Jan 23, 2024

heavyweight left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agrullon95 commented Jan 12, 2024 •

edited by alshakero

Loading

github-actions bot commented Jan 12, 2024 •

edited

Loading

github-actions bot commented Jan 12, 2024 •

edited

Loading

agrullon95 Jan 12, 2024 •

edited

Loading

agrullon95 Jan 22, 2024 •

edited

Loading