Google Fonts: Prevent the default fonts from overridden by the theme fonts

[arthur791004]

Fixes Automattic/wp-calypso#84590

Proposed changes:

• Currently, the fonts provided by both the theme and Jetpack Google Fonts might not render correctly if the theme only supports a specific set of font weights. The reason was the theme fonts have a higher priority.
• As a result, this PR proposes to prevent the theme fonts from overriding the default fonts. With this change, all font weights of the font supported by Jetpack Google Fonts can render correctly. The downside is the font family name will be duplicated in the dropdown list but I think it's fine as it's the same as the installed fonts.

The screenshot of applying the “Extra Light” appearance

	Before	After
Editor
Frontend

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Follow Google Fonts: Prevent the default fonts from overridden by the theme fonts #37050 (comment) to apply changes to your site
• Activate Adventurer theme
• Go to the Site Editor
• Change the font weight of the heading
• Make sure it works as expected
• Save the changes and preview your site
• Make sure it works on the frontend page as well

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for May 7, 2024 (scheduled code freeze on May 6, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the feat/dont-override-default-fonts branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack feat/dont-override-default-fonts
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[miksansegundo]

LGTM 👍

Screen.Recording.2567-04-25.at.00.32.30.mov

As expected, it only works for the weights the font supports.

What is unexpected is to see unsupported weights in the dropdown, but that's a different issue. See WordPress/gutenberg#49090

As expected, the font is duplicated in the fonts dropdown, which is acceptable IMO. Do you think the duplication could be fixed in Gutenberg?

Shouldn't we expect all the fonts to be in alphabetical order? I'll create an issue in Gutenberg if you think that's unexpected.

BTW Here is a tracking issue for the Font Library WordPress/gutenberg#60528

[arthur791004]

As expected, the font is duplicated in the fonts dropdown, which is acceptable IMO. Do you think the duplication could be fixed in Gutenberg?

Yes, I think so!

Shouldn't we expect all the fonts to be in alphabetical order? I'll create an issue in Gutenberg if you think that's unexpected.

Yes, it would be better! Thank you!