Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto open "Upload Theme" dialog when wpcom-upload=1 param exists #39045

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

DustyReagan
Copy link
Member

@DustyReagan DustyReagan commented Aug 22, 2024

Fixes Automattic/wp-calypso#93594

Proposed changes:

  • This PR opens the "Upload Theme" dialog by default on /wp-admin/theme-install.php when wpcom-upload=1 is included as URL paramter
Screenshot 2024-08-22 at 6 00 12 PM

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Load this PR using the instructions in the comment below.
  • Go to /wp-admin/theme-install.php?wpcom-upload=1
  • The upload dialog should be open. Click the "Upload Theme" button to toggle it close.
  • Go to /wp-admin/theme-install.php
  • The upload dialog should be closed. Click the "Upload Theme" button to toggle it open.

Copy link
Contributor

github-actions bot commented Aug 22, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/auto-open-upload-theme branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/auto-open-upload-theme
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Aug 22, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Aug 22, 2024
@DustyReagan DustyReagan changed the title Add/auto open upload theme Auto open "Upload Them" dialog when wpcom-upload=1 param exists Aug 22, 2024
@DustyReagan DustyReagan changed the title Auto open "Upload Them" dialog when wpcom-upload=1 param exists Auto open "Upload Theme" dialog when wpcom-upload=1 param exists Aug 22, 2024
@DustyReagan DustyReagan self-assigned this Aug 22, 2024
@DustyReagan DustyReagan added [Status] Needs Team Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Aug 22, 2024
@DustyReagan DustyReagan requested review from mmtr and a team August 22, 2024 23:15
Copy link
Contributor

@dsas dsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, works for me.

@DustyReagan DustyReagan merged commit ebbd392 into trunk Aug 23, 2024
61 of 63 checks passed
@DustyReagan DustyReagan deleted the add/auto-open-upload-theme branch August 23, 2024 15:27
anomiex pushed a commit that referenced this pull request Aug 23, 2024
Fix jetpack-mu-wpcom and wpcomsh package versions after #39045 was
merged in between when #39054 was created and when it was merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme Showcase: Improve the Install New Theme flow for WoA
2 participants