Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social: Disable sharing UI for invalid connections #39346

Merged

Conversation

manzoorwanijk
Copy link
Member

@manzoorwanijk manzoorwanijk commented Sep 11, 2024

Proposed changes:

  • Disable reshare button and hide post publish share status when all the enabled connections are invalid

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Add a Facebook and an Instagram connection
  • Edit an existing post
  • Open Jetpack/Social sidebar and enable SIG
  • Enable only the Instagram connection
  • Now disable SIG to make the Instagram connection invalid due to no media
  • Confirm that the "Share post" button is disabled
  • Now enable any other connection
  • Confirm that the button is enabled again
  • Go to https://www.facebook.com/settings/?tab=business_tools and remove Jetpack to make the connection broken
  • Create a new post and disable all other valid connections.
  • Publish the post
  • On the post publish panel, confirm that you don't see "Sharing your post..."
  • Now create another post with other connections enabled
  • Confirm that the share status show up fine.
  • Edit an existing post
  • Open Jetpack/Social sidebar
  • Quickly enable broken Facebook and Instagram connections before the test results finish
  • Wait for connection test results to finish
  • Confirm that "Share post" button is now disabled because only the invalid connections are enabled.
  • Now enable any other connection
  • Confirm that the "Share post" button is enabled again

Copy link
Contributor

github-actions bot commented Sep 11, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/social/disable-sharing-for-invalid-connections branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/social/disable-sharing-for-invalid-connections
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Copy link
Contributor

@gmjuhasz gmjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and works well!

Just had a question to confirm one thing

@manzoorwanijk manzoorwanijk merged commit 313dad5 into trunk Sep 13, 2024
59 checks passed
@manzoorwanijk manzoorwanijk deleted the update/social/disable-sharing-for-invalid-connections branch September 13, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants