Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack AI: don't generate first logo without details #39536

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from

Conversation

CGastrell
Copy link
Contributor

Proposed changes:

  • remove noisy debug call
  • add logo-presenter empty placeholder
  • add logo-history empty placeholder
  • check if we have site title and description
  • check that site title is not the default (flaky)

The newly introduced empty placeholders need some design:
image

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pe4Cmx-2Ma-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Use a fresh site (or delete logo history from the devtools application tab, localStorage). Go to site general settings and set an empty title and description.

Go to the editor and insert a logo block. Use the AI toolbar button to open the modal.

See that the modal doesn't trigger an immediate request to generate a logo.
See the empty placeholders.

Go back to settings and choose a title and description for the site, then back to the editor. Click the AI toolbar button on the logo block. This time, the modal should show a generation is in progress and eventually bring back the new logo.

See that the "Use on Site" button is now variant=secondary, making it more prominent.

@CGastrell CGastrell added [Status] Needs Team Review [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [JS Package] AI Client labels Sep 25, 2024
@CGastrell CGastrell requested a review from a team September 25, 2024 20:33
@CGastrell CGastrell self-assigned this Sep 25, 2024
Copy link
Contributor

github-actions bot commented Sep 25, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the change/jetpack-ai-logo-first-generation-condition branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack change/jetpack-ai-logo-first-generation-condition
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added the RNA label Sep 25, 2024
Copy link
Contributor

github-actions bot commented Sep 25, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for November 5, 2024 (scheduled code freeze on November 4, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@CGastrell CGastrell force-pushed the change/jetpack-ai-logo-first-generation-condition branch from 3525c9b to bfc8931 Compare September 30, 2024 14:16
@CGastrell CGastrell force-pushed the change/jetpack-ai-logo-first-generation-condition branch from bfc8931 to eba4bf5 Compare October 2, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JS Package] AI Client [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA [Status] Needs Team Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant