-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack AI: don't generate first logo without details #39536
base: trunk
Are you sure you want to change the base?
Jetpack AI: don't generate first logo without details #39536
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
3525c9b
to
bfc8931
Compare
bfc8931
to
eba4bf5
Compare
Proposed changes:
The newly introduced empty placeholders need some design:
Other information:
Jetpack product discussion
pe4Cmx-2Ma-p2
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Use a fresh site (or delete logo history from the devtools application tab, localStorage). Go to site general settings and set an empty title and description.
Go to the editor and insert a logo block. Use the AI toolbar button to open the modal.
See that the modal doesn't trigger an immediate request to generate a logo.
See the empty placeholders.
Go back to settings and choose a title and description for the site, then back to the editor. Click the AI toolbar button on the logo block. This time, the modal should show a generation is in progress and eventually bring back the new logo.
See that the "Use on Site" button is now
variant=secondary
, making it more prominent.