Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VideoPress block connection banner, align with other blocks #39628

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

CodeyGuyDylan
Copy link
Contributor

@CodeyGuyDylan CodeyGuyDylan commented Oct 2, 2024

Proposed changes:

  • Update styling for VideoPress block connection banner to closely match Jetpack AI's nudge
  • Update copy and functionality of banner to send to connection screen if no user is connected to the site, and to the settings page if only disabled (previously was always going to settings page)
  • Disable controls on block until module is activated and site has a connected user

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

P2: pbNhbs-bHl-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  1. Checkout this branch via the Jetpack Beta plugin or your local dev environment
  2. Start by site-only connecting your site
  3. Create a new blog post
  4. Add a VideoPress and Jetpack AI block to the screen so you can compare the two. Save the blog post so you don't have to add the blocks every time
    image
  5. Make sure the design is the same and that both scale to mobile the same way

NOTE: The only styling I didn't align was the font. The VideoPress nudge uses Inter (which is what we want), the AI block does not use that, possibly will fix that in a future task on this project

  1. Click on "Connect Jetpack" and ensure you are sent through the regular connection flow
    image

NOTE: This connection flow is bad, and does not lead the user back to VideoPress in any way. I wrote about that in P2 (pbNhbs-bHl-p2#comment-23858) and regardless of the outcome of that conversation, fixing that will be outside the scope of this PR

  1. After connecting your user, go back to your blog post ( you can delete the AI block now ). Confirm that you now see a nudge to "Activate" VideoPress
    image

  2. Click on the CTA and ensure you are taken to settings where you can activate VideoPress
    image

  3. Activate VideoPress and go back to your blog post. You should be able to use the block now
    image

Bonus!

  1. With VideoPress still activated, disconnect your user account from your site (but re-connect your site connection). Go back to your blog post and you should see the Connect CTA and copy, not Activate
    image

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/jetpack-blocks-confusing-connection-nudges branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/jetpack-blocks-confusing-connection-nudges
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Oct 2, 2024
@CodeyGuyDylan CodeyGuyDylan changed the title Update/jetpack blocks confusing connection nudges Update VideoPress block connection banner, align with other blocks Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] VideoPress [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VideoPress: Update notice for disabled VideoPress module to show Enable instead of Connect
1 participant