-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update VideoPress block connection banner, align with other blocks #39628
base: trunk
Are you sure you want to change the base?
Update VideoPress block connection banner, align with other blocks #39628
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
Proposed changes:
Other information:
Jetpack product discussion
P2: pbNhbs-bHl-p2
Does this pull request change what data or activity we track or use?
No
Testing instructions:
NOTE: The only styling I didn't align was the font. The VideoPress nudge uses Inter (which is what we want), the AI block does not use that, possibly will fix that in a future task on this project
NOTE: This connection flow is bad, and does not lead the user back to VideoPress in any way. I wrote about that in P2 (pbNhbs-bHl-p2#comment-23858) and regardless of the outcome of that conversation, fixing that will be outside the scope of this PR
After connecting your user, go back to your blog post ( you can delete the AI block now ). Confirm that you now see a nudge to "Activate" VideoPress
Click on the CTA and ensure you are taken to settings where you can activate VideoPress
Activate VideoPress and go back to your blog post. You should be able to use the block now
Bonus!
Connect
CTA and copy, notActivate