Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPress: use "Processing" thumbnail placeholder while a new thumbnail is being saved #39631

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

lhkowalski
Copy link
Contributor

@lhkowalski lhkowalski commented Oct 2, 2024

Part of #39524.

Proposed changes:

  • The thumbnail update is a process that depends on the backend generating the new image file and updating the video information
  • This may take some time, and while the image is being processed, the video details edit page inside VideoPress dashboard was showing the old thumbnail after saving the changes, what could be misleading to users (and result on people refreshing the page and getting a broken, 404 thumbnail)
  • We have, on the local state, a prop to control the poster updating status, so this PR is using it to set a "Processing" thumbnail placeholder while the image is not ready on the backend

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Make sure you have a Jetpack site with a VideoPress license and with the VideoPress standalone plugin installed, so you have access to the VideoPress Dashboard
  • Go to Jetpack > VideoPress and upload a new file
  • After the upload is ready, click the "Edit video details" button
  • On the video thumbnail preview, click the pencil button to edit the thumbnail and then click "Select from video"
  • Choose a different thumbnail and click "Select this frame"
  • Click "Save changes"
  • Confirm the video thumb component will show a processing message while the details are saved
  • Confirm the video thumb keeps showing a processing message even after the "save" action is done, because the new video thumb is still being processed
  • Confirm the new video thumb will eventually load properly

Video showing what to expect:

Screen.Recording.2024-10-02.at.17.35.18.mov

@lhkowalski lhkowalski requested a review from a team October 2, 2024 20:54
@lhkowalski lhkowalski self-assigned this Oct 2, 2024
@lhkowalski lhkowalski marked this pull request as ready for review October 2, 2024 20:55
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/videopress-update-thumb-placeholder-while-updating branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/videopress-update-thumb-placeholder-while-updating
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant