Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation and naming #45

Merged
merged 7 commits into from
Mar 29, 2024
Merged

Improve documentation and naming #45

merged 7 commits into from
Mar 29, 2024

Commits on Mar 29, 2024

  1. docs: add Javadoc comments for plugin extension

    @wzieba
    wzieba committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    bc38b03 View commit details
    Browse the repository at this point in the history

  2. refactor: move default values to Property#convention set in plugin'… 

    …s extension

This way we keep all defaults in a single place.
    @wzieba
    wzieba committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    af6a04a View commit details
    Browse the repository at this point in the history

  3. feat: add a log (instead of crashing) if user doesn't provide `buildM… 

    …etricsPreparedAction`
    @wzieba
    wzieba committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    9b66ca4 View commit details
    Browse the repository at this point in the history

  4. refactor: rename buildMetricsPrepared to onBuildMetricsReady. 

    It might be a personal preference, but "on" prefix feels more obvious for a listener.
    @wzieba
    wzieba committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    3a7b5b7 View commit details
    Browse the repository at this point in the history

  5. docs: update README

    @wzieba
    wzieba committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    2c5ec5a View commit details
    Browse the repository at this point in the history

  6. revert making InMemoryMetricsReporter internal 

    It doesn't seem to change anything
    @wzieba
    wzieba committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    acef75c View commit details
    Browse the repository at this point in the history

  7. tests: update after listener rename

    @wzieba
    wzieba committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    3af05e8 View commit details
    Browse the repository at this point in the history