Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acknowledged: false should also generate descriptive logging #14951

Closed
2 tasks done
markstos opened this issue Oct 10, 2024 · 1 comment · Fixed by #14957
Closed
2 tasks done

acknowledged: false should also generate descriptive logging #14951

markstos opened this issue Oct 10, 2024 · 1 comment · Fixed by #14957

Comments

@markstos
Copy link
Contributor

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

In certain cases, an result of {acknowledged: false} can be returned. The official docs say vaguely that this means "things didn't go smoothly".

To resolve the issue of why it didn't go smoothly, it would be of great help if there were more logging about what exactly went wrong-- this would still be useful even if it was only emitted at the debug logging level.

#14936 is an example where a user is spending a lot of time how to resolve an "{acknowlwedged: false}" issue after an upgrade.

The more precise the logging about this could be, the faster the true root cause can found and addressed.

Ref: Here's where it's mentioned:

@markstos
Copy link
Contributor Author

Thanks @vkarpov15 !

I updated the related discussion after I came to understand the root cause of why I was running to this tonight:

#14936

vkarpov15 added a commit that referenced this issue Oct 14, 2024
docs(model): add more info on acknowledged: false, specifically that Mongoose may return that if the update was empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant