Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(model): add test for issue #8040 re: #8048 #8326 #8341

Merged
merged 1 commit into from
Nov 14, 2019
Merged

test(model): add test for issue #8040 re: #8048 #8326 #8341

merged 1 commit into from
Nov 14, 2019

Conversation

Fonger
Copy link
Contributor

@Fonger Fonger commented Nov 14, 2019 •
edited
Loading

Summary

Add test to make sure $__.$versionError $__.saveOptions are generated during saving and are cleared after saved to prevent memory leak.

#8326 (comment)

vkarpov15: I'll merge this for now, but can you also write a test for this please? Basically make sure that $versionError exists before and no longer exists after.

vkarpov15
vkarpov15 approved these changes Nov 14, 2019
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vkarpov15 vkarpov15 added this to the 5.7.11 milestone Nov 14, 2019
@vkarpov15 vkarpov15 merged commit e268572 into Automattic:master Nov 14, 2019
This was referenced Mar 15, 2021
Open
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.7.11
Development

Successfully merging this pull request may close these issues.
2 participants
@Fonger @vkarpov15