Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model): delete $versionError after saving to prevent memory leak #8326

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

Fonger
Copy link
Contributor

@Fonger Fonger commented Nov 12, 2019

The original fix in PR #8048 has a typo. This PR really fixes the issue.

The original fix in PR Automattic#8048 has a typo. This really fix the issue.
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vkarpov15
Copy link
Collaborator

I'll merge this for now, but can you also write a test for this please? Basically make sure that $versionError exists before and no longer exists after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants