Add Path generic #13117
Merged
Add Path generic #13117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't yelling at me
vkarpov15
approved these changes
Mar 2, 2023
| }); | ||
|
|
||
| const parent = model<IParent>('Parent', parentSchema); | ||
| const child = model<IChild>('Child', childSchema); |
There was a problem hiding this comment.
We always use capitalized names for models
| const child = model<IChild>('Child', childSchema); | ||
|
|
||
| const doc = await parent.findOne(); | ||
| await child.populate<{child: IChild}>(doc, 'child'); |
There was a problem hiding this comment.
Didn't actually test that the result doc is correctly populated. Missed this:
mongoose/test/types/populate.test.ts
Line 126 in 7d2c511
| @@ -303,7 +303,8 @@ declare module 'mongoose' { | |||
| callback?: Callback<(HydratedDocument<T, TMethodsAndOverrides, TVirtuals>)[]>): Promise<Array<HydratedDocument<T, TMethodsAndOverrides, TVirtuals>>>; | |||
| populate(doc: any, options: PopulateOptions | Array<PopulateOptions> | string, | |||
| callback?: Callback<HydratedDocument<T, TMethodsAndOverrides, TVirtuals>>): Promise<HydratedDocument<T, TMethodsAndOverrides, TVirtuals>>; | |||
|
|
|||
| populate<Paths={}>(docs: Array<any>, options: PopulateOptions | Array<PopulateOptions> | string): Promise<MergeType<this, Paths>>; | |||
There was a problem hiding this comment.
If you had actually tested the populate doc result, you'd see that this is the wrong type to use here. In this context, this is the Model class, not the document. Use the other populate() calls on Model as an example for how to do this correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't yelling at me.
Also, while working on this issue I noticed the populate section is more focused on query population than calling
Model.populate(). Maybe we should include a small section about that function since we have a section titledPopulatein the docs.