Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check discriminator existence before accessing schema in getModelsMapForPopulate #8878

Merged
merged 2 commits into from
Apr 30, 2020
Merged

check discriminator existence before accessing schema in getModelsMapForPopulate #8878

merged 2 commits into from
Apr 30, 2020

Conversation

AbdelrahmanHafez
Copy link
Collaborator

fixes #8837

vkarpov15
vkarpov15 approved these changes Apr 30, 2020
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 merged commit 872ab26 into Automattic:master Apr 30, 2020
@AbdelrahmanHafez AbdelrahmanHafez deleted the gh-8837-master branch April 30, 2020 19:04
@qqilihq
Copy link

qqilihq commented May 1, 2020

Thank you!

@AbdelrahmanHafez
Copy link
Collaborator Author

Happy to help 👍

@Hajjiri Hajjiri mentioned this pull request Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot read property 'schema' of undefined for discriminated nested array when using refPath
3 participants
@AbdelrahmanHafez @qqilihq @vkarpov15