Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(document): disallow transform functions that return promises #9176

Merged
merged 6 commits into from
Jul 1, 2020
Merged

fix(document): disallow transform functions that return promises #9176

merged 6 commits into from
Jul 1, 2020

Conversation

AbdelrahmanHafez
Copy link
Collaborator

fixes #9163

vkarpov15
vkarpov15 approved these changes Jul 1, 2020
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just made a quick tweak to the error message.

@vkarpov15 vkarpov15 added this to the 5.9.21 milestone Jul 1, 2020
@vkarpov15 vkarpov15 merged commit 316f922 into Automattic:master Jul 1, 2020
@AbdelrahmanHafez
Copy link
Collaborator Author

That is clearer, thank you.

This was referenced Mar 14, 2021
Closed
Closed
@AbdelrahmanHafez AbdelrahmanHafez mentioned this pull request Sep 1, 2022
Merged
@hasezoey hasezoey mentioned this pull request Sep 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.9.21
Development

Successfully merging this pull request may close these issues.

Throw error when transform returns a promise
2 participants
@AbdelrahmanHafez @vkarpov15