Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mongoskin version for memory fix on arm for bson #59

Closed
wants to merge 2 commits into from

Conversation

hanscappelle
Copy link

Please consider completing this request. One test is failing after this update. The err in collection destroy function has no message. Other tests run fine.

  1. collection finding should allow stream cursor destroy:
    Uncaught TypeError: Cannot read property 'message' of null
    at /Users/hcpl/Development/git/monk-hcpl/lib/collection.js:393:48

Details on memory issue for arm are available at https://github.com/mongodb/js-bson/issues/37

@hanscappelle
Copy link
Author

I just found out that before this change I would get the below errors on an up to date mac running node V0.10.23 in combination with some express routes where I would have data fetched using monk. Let me know if someone needs more information on that.

(node) warning: Recursive process.nextTick detected. This will break in the next version of node. Please use setImmediate for recursive deferral.

RangeError: Maximum call stack size exceeded

@juancancela
Copy link

Hi, actually im having exactly the same issue (RangeError: Maximum call stack size exceeded). Im using Monk 0.8.1 and Node 0.10.26. Do you know what is the root cause and how can i fix it? Thanks!

@hanscappelle
Copy link
Author

Do you still have the error with my fork?

You can also navigate into the node_modules/monk folder in your project and edit the package.json file to update mongoskin version and then execute npm install from that folder.

The mongoskin version you need is the latest before they switched to mongodb matching versions. So something 0..

@juancancela
Copy link

Ha Hans,
actually seems that the issue im facing is related to a bug in node core: nodejs/node-v0.x-archive#6065 Bug was marked as WONTFIX for 0.10.x, and Node devs said that it is already fixed on 0.11.x. I tried 0.11 and is not reproducible. So, seems that updating Node is the way to go (sadly is not the master, but a branch currently in test, so it can be potentially less stable)

@rauchg
Copy link
Contributor

rauchg commented May 14, 2014

We updated it.

@rauchg rauchg closed this May 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants