Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add methods that were in mailchimp data connector #1568

Merged

Conversation

leogermani
Copy link
Contributor

@leogermani leogermani commented Jul 11, 2024

All Submissions:

Changes proposed in this Pull Request:

Brings the updated functionality of preparing merge fields that was present in the Mailchimp data api connector

How to test the changes in this Pull Request:

See Automattic/newspack-plugin#3237

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@leogermani leogermani self-assigned this Jul 11, 2024
@leogermani leogermani marked this pull request as ready for review July 11, 2024 18:24
@leogermani leogermani requested a review from a team as a code owner July 11, 2024 18:24
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 56.92308% with 28 lines in your changes missing coverage. Please review.

Project coverage is 18.27%. Comparing base (c029516) to head (f34f74a).

Files Patch % Lines
...mailchimp/class-newspack-newsletters-mailchimp.php 56.92% 28 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##             epic/consolidate-data-flows    #1568      +/-   ##
=================================================================
+ Coverage                          17.78%   18.27%   +0.49%     
- Complexity                          2296     2302       +6     
=================================================================
  Files                                 44       44              
  Lines                               8706     8731      +25     
=================================================================
+ Hits                                1548     1596      +48     
+ Misses                              7158     7135      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from refactor/deprecate-add-contact to epic/consolidate-data-flows July 11, 2024 20:35
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected here too 👍

@leogermani leogermani merged commit 536f9cd into epic/consolidate-data-flows Jul 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Approved Ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants