Add/logging

[leogermani]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Adds logging to contact syncing

How to test the changes in this Pull Request:

See https://github.com/Automattic/newspack-manager/pull/240

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[codecov]

Codecov Report

Attention: Patch coverage is 42.01681% with 69 lines in your changes missing coverage. Please review.

Project coverage is 18.54%. Comparing base (da82e1d) to head (234868d).

Files	Patch %	Lines
includes/class-newspack-newsletters-contacts.php	32.07%	36 Missing ⚠️
...imp/class-newspack-newsletters-mailchimp-notes.php	68.75%	15 Missing ⚠️
...cludes/class-newspack-newsletters-subscription.php	0.00%	11 Missing ⚠️
...rs/class-newspack-newsletters-service-provider.php	0.00%	4 Missing ⚠️
includes/plugins/class-woocommerce-memberships.php	0.00%	3 Missing ⚠️

Additional details and impacted files

@@                       Coverage Diff                        @@
##             update/update-method-calls    #1574      +/-   ##
================================================================
+ Coverage                         18.21%   18.54%   +0.33%     
- Complexity                         2313     2333      +20     
================================================================
  Files                                44       45       +1     
  Lines                              8760     8852      +92     
================================================================
+ Hits                               1596     1642      +46     
- Misses                             7164     7210      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[adekbadek]

@leogermani – just noting that tests are not passing. Should be fixed before a CR.

[claudiulodro]

Looks great! I think it's important to add the site URL to the MC notes, because there have been situations before where multiple sites were syncing to the same MC and causing weird data. This will make it easy to identify that situation.

[dkoo]

Only noticed one issue with an undefined variable upon deleting a user.