Updating Types #1509
Merged
Updating Types #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two missing types that I am requesting to add. `jpg` support and on the NodeCanvasRenderingContext2D
zbjornson
requested changes
Jan 9, 2020
| /** | ||
| * An additional method .addPage() is then available to create multiple page PDFs | ||
| */ | ||
| addPage(width?: number, height?: number): void |
There was a problem hiding this comment.
Oops, good catch. Can you delete the incorrect declaration from line 130-134 (I had it on the Canvas instance instead of the rendering context) please? You could also copy the text from it that describes the default width/height values.
types/index.d.ts
Outdated
| @@ -78,7 +78,7 @@ export class Canvas { | |||
| /** Constant used in PNG encoding methods. */ | |||
| readonly PNG_FILTER_PAETH: number | |||
|
|
|||
| constructor(width: number, height: number, type?: 'pdf'|'svg') | |||
| constructor(width: number, height: number, type?: 'pdf'|'svg'|'jpg') | |||
There was a problem hiding this comment.
'jpg' isn't a valid Canvas type, just 'pdf' and 'svg'. Anything else is ignored and creates an image canvas. If you want you could add 'image' here to maybe improve clarity...
Lines 105 to 110 in 37d556c
There was a problem hiding this comment.
Ahh thanks for that clarity! Updated
Closed
|
Could you do a release to include this? Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two missing types that I am requesting to add.
jpgsupport and on the NodeCanvasRenderingContext2D