Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dtslint with tsd #2313

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Replace dtslint with tsd #2313

merged 1 commit into from
Nov 29, 2023

Conversation

LinusU
Copy link
Collaborator

@LinusU LinusU commented Nov 28, 2023

Thanks for contributing!

  • Have you updated CHANGELOG.md?

@LinusU
Copy link
Collaborator Author

LinusU commented Nov 28, 2023

Since dtslint was deprecated, and their replacement @definitelytyped/dtslint was on a 0.0.x version, and since they also recommended tsd, I thought it was better to use tsd over @definitelytyped/dtslint.

This also simplifies the entire setup a bit, with the potential drawback that the types files isn't linted for stylistic changes (but this should probably be handled by Standard anyways)

Comment on lines +47 to +49
"browser.js",
"index.d.ts",
"index.js",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially, this aren't needed, but the files documentation only mentions main, and I think it's better to just include them all...

@LinusU
Copy link
Collaborator Author

LinusU commented Nov 28, 2023

The tests are failing for unrelated reasons, but this fixes the "Lint" check so I think that we could merge this, and then I can rebase #2310 on top of this...

Copy link
Collaborator

@zbjornson zbjornson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 cool

@zbjornson zbjornson merged commit 7132087 into master Nov 29, 2023
21 of 38 checks passed
@zbjornson zbjornson deleted the lu-tsd branch November 29, 2023 02:16
@LinusU LinusU mentioned this pull request Nov 29, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants