Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Auto: Update the progress bar in the browse view #2945

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

geekygecko
Copy link
Member

@geekygecko geekygecko commented Sep 27, 2024

Description

An automotive manufacturer asked if we could add the progress bar to the browse view. There is a Google guide for this.

Testing Instructions

  1. Start the Android Auto emulator.
cd /Applications/android-sdk/extras/google/auto/
chmod +x ./desktop-head-unit
./desktop-head-unit --usb
  1. Plugin in your device over USB
  2. Play an episode and skip to move progress along
  3. Open the podcast page
    ✅ Verify the episode row now shows a progress bar

You may need to go to one level higher in the menu and back again for the episode row to update. I don't believe there is a way to fix this in Android Auto or Automotive.

Screenshots

Before
Screenshot 2024-09-28 at 9 16 58 AM

After

Screenshot 2024-09-28 at 9 15 07 AM

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@geekygecko geekygecko added [Area] Android Auto Android Auto integration through a phone [Type] Enhancement Improve an existing feature. labels Sep 27, 2024
@geekygecko geekygecko added this to the 7.74 milestone Sep 27, 2024
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 27, 2024

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commite56e9fe
Direct Downloadpocketcasts-app-prototype-build-pr2945-e56e9fe.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commite56e9fe
Direct Downloadpocketcasts-automotive-prototype-build-pr2945-e56e9fe.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commite56e9fe
Direct Downloadpocketcasts-wear-prototype-build-pr2945-e56e9fe.apk

@geekygecko geekygecko marked this pull request as ready for review September 28, 2024 00:08
@geekygecko geekygecko requested a review from a team as a code owner September 28, 2024 00:08
@geekygecko geekygecko requested review from mebarbosa and removed request for a team September 28, 2024 00:08
Copy link
Contributor

@mebarbosa mebarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

The code looks good, but I found an issue with the progress sync if I have the in progress episodes opened.

  1. You can start listening some episodes to have the in progress list populated
  2. Open the in progress episodes tab
  3. Play some episode
  4. Seek to the end
  5. Back to in progress list
  6. You will see the episode is not updated with the current progress.
automotive.test.mov

I had to refresh the page to get the episode progress updated

@mebarbosa mebarbosa modified the milestones: 7.74, 7.75 Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Area] Android Auto Android Auto integration through a phone [Type] Enhancement Improve an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants