-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android Auto: Update the progress bar in the browse view #2945
Open
geekygecko
wants to merge
2
commits into
main
Choose a base branch
from
task/automotive-progress
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekygecko
added
[Area] Android Auto
Android Auto integration through a phone
[Type] Enhancement
Improve an existing feature.
labels
Sep 27, 2024
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
|
mebarbosa
requested changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement!
The code looks good, but I found an issue with the progress sync if I have the in progress episodes opened.
- You can start listening some episodes to have the in progress list populated
- Open the in progress episodes tab
- Play some episode
- Seek to the end
- Back to in progress list
- You will see the episode is not updated with the current progress.
automotive.test.mov
I had to refresh the page to get the episode progress updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Area] Android Auto
Android Auto integration through a phone
[Type] Enhancement
Improve an existing feature.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An automotive manufacturer asked if we could add the progress bar to the browse view. There is a Google guide for this.
Testing Instructions
✅ Verify the episode row now shows a progress bar
You may need to go to one level higher in the menu and back again for the episode row to update. I don't believe there is a way to fix this in Android Auto or Automotive.
Screenshots
Before
After
Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml
I have tested any UI changes...