Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rainfall: address header and footer improvements #6305

Merged
merged 11 commits into from
Aug 4, 2022
Merged

Conversation

mikachan
Copy link
Member

@mikachan mikachan commented Aug 1, 2022

Changes proposed in this Pull Request:

This addresses most of the feedback in #6245.

I haven't been able to address all of it as I've tried to stick with what's currently available from GB, but let me know if we should manually add anything.

  1. Header and footer are now full width

  2. Footer text is now uppercase by default (I also made the links a navigation block)
    image

  3. Styled the mobile menu further:

We are currently able to swap the hamburger menu for text that says 'menu', but there is currently no option for replacing the 'X' with text (issue here: WordPress/gutenberg#42848).

image

This is how the overlay looks now:
image

I haven't included the social menu in the overlay as this currently isn't possible in GB (I don't think?)

I've also styled the current menu item, but it looks like there's a bug with the current-menu-item class. Fix here: WordPress/gutenberg#42849

  1. Fixed how the footer menu wraps at mobile
    image

Related issue(s):

#6245

@mikachan mikachan self-assigned this Aug 1, 2022
@scruffian
Copy link
Member

I added a commit to remove the link color from the header group as it was breaking the overlay colors.

@mikachan
Copy link
Member Author

mikachan commented Aug 2, 2022

I added a commit to remove the link color from the header group as it was breaking the overlay colors.

Nice, thanks!

@beafialho
Copy link
Collaborator

Thank you! Header and footer alignments and letter case look good.

I've also styled the current menu item, but it looks like there's a bug with the current-menu-item class.

I notice there's a tiny misplacement of the current menu item, is that the bug?

Captura de ecrã 2022-08-03, às 14 51 14

We are currently able to swap the hamburger menu for text that says 'menu', but there is currently no option for replacing the 'X' with text (issue here: WordPress/gutenberg#42848).

Thanks for opening that one!

I haven't included the social menu in the overlay as this currently isn't possible in GB (I don't think?)

Ok, let's leave it like that for now.

I'm not sure this is the step to address this but the navigation links currently have no hover states. Those are specified here.

@mikachan
Copy link
Member Author

mikachan commented Aug 3, 2022

Thanks @beafialho!

I notice there's a tiny misplacement of the current menu item, is that the bug?

I think this is due to the font-weight. We could probably fix it by specifying a different line-height for the current item.. I can take a proper look into it.

I'm not sure this is the step to address this but the navigation links currently have no hover states.

Ah yeah, we can address this next!

@mikachan mikachan merged commit 7dad33c into trunk Aug 4, 2022
@mikachan mikachan deleted the fix/rainfall-6245 branch August 4, 2022 07:58
@mikachan mikachan linked an issue Aug 17, 2022 that may be closed by this pull request
@mikachan mikachan added this to the Rainfall milestone Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rainfall: Header and Footer improvements
3 participants