Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fictionary: Add new theme #8081

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Fictionary: Add new theme #8081

merged 2 commits into from
Sep 20, 2024

Conversation

MaggieCabrera
Copy link
Contributor

@MaggieCabrera MaggieCabrera commented Sep 6, 2024

pNEWy-hZB-p2

@MaggieCabrera MaggieCabrera added the Ready to launch Add this label if this is the first PR for a new theme label Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Preview changes

I've detected changes to the following themes in this PR: Fictionary.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@MaggieCabrera MaggieCabrera added Ready to launch Add this label if this is the first PR for a new theme and removed Ready to launch Add this label if this is the first PR for a new theme labels Sep 10, 2024
@alaczek
Copy link
Contributor

alaczek commented Sep 11, 2024

A had a quick look at this one:

  • I'm not sure we need to include images with this theme as they are not used in templates/patterns.
  • We had a discussion a while back and decided not to include copyright messages in themes: pekYwv-4ok-p2
  • the home template has a static link that goes to staging site (I think the link can be removed)
  • the footer template part is not using the footer pattern

@iamtakashi iamtakashi self-assigned this Sep 18, 2024
@iamtakashi
Copy link
Contributor

I'm cleaning up this theme now.

Copy link
Contributor

Theme-Check results

fictionary: No changes required ✅.

💡 RECOMMENDED (2)
  • No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
  • No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
ℹ️ INFO (1)
  • Only one text-domain is being used in this theme. Make sure it matches the theme's slug correctly so that the theme will be compatible with WordPress.org language packs. The domain found is fictionary.

@iamtakashi
Copy link
Contributor

I addressed all the feedback and cleaned it up so it has a better chance of being approved in the theme review.

@iamtakashi
Copy link
Contributor

@alaczek I thought you might want to review it with the changes I made, but It passed the automated check, so I'll merge it and move on. 🏃‍♂️

@iamtakashi iamtakashi merged commit e79a4a1 into trunk Sep 20, 2024
3 checks passed
@iamtakashi iamtakashi deleted the add-fictionary branch September 20, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to launch Add this label if this is the first PR for a new theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants